Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin-rebuild: add page, home-manager: edit page #15175

Merged
merged 16 commits into from
Dec 26, 2024
Merged

darwin-rebuild: add page, home-manager: edit page #15175

merged 16 commits into from
Dec 26, 2024

Conversation

Abhishek-1804
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): N/A

@github-actions github-actions bot added new command Issues requesting creation of a new page. page edit Changes to an existing page(s). labels Dec 16, 2024
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/home-manager.md:25: TLDR008 File should contain no trailing whitespace

Please fix the error(s) and push again.

@Abhishek-1804 Abhishek-1804 changed the title Improve home manager docs darwin-rebuild: add page, home-manager: edit page Dec 16, 2024
@Abhishek-1804 Abhishek-1804 force-pushed the improve-home-manager-docs branch from c44e954 to c6b36a8 Compare December 16, 2024 04:07
acuteenvy
acuteenvy approved these changes Dec 16, 2024
View reviewed changes
pages/osx/darwin-rebuild.md Outdated Show resolved Hide resolved
pages/osx/darwin-rebuild.md Outdated Show resolved Hide resolved
Abhishek-1804 and others added 4 commits December 16, 2024 22:40
@Abhishek-1804
Merge branch 'main' into improve-home-manager-docs
8a98c18
@Abhishek-1804 @acuteenvy
Update pages/osx/darwin-rebuild.md
dc4fda6 
Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
@Abhishek-1804 @acuteenvy
Update pages/osx/darwin-rebuild.md
f7cf505 
Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
@Abhishek-1804
Merge branch 'main' into improve-home-manager-docs
6202249
@Abhishek-1804 Abhishek-1804 force-pushed the improve-home-manager-docs branch from d511ff9 to de0363d Compare December 18, 2024 15:50
@Abhishek-1804
Copy link
Contributor Author

Abhishek-1804 commented Dec 18, 2024 •
edited
Loading

@kant @cyqsimon @sebastiaanspeck Hi, Could you please review this pr?

@Abhishek-1804 Abhishek-1804 force-pushed the improve-home-manager-docs branch 2 times, most recently from f3da66b to baeca30 Compare December 18, 2024 23:33
@Abhishek-1804 Abhishek-1804 force-pushed the improve-home-manager-docs branch from baeca30 to 4eba78e Compare December 19, 2024 18:09
kbdharun
kbdharun approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit 90a67cb into tldr-pages:main Dec 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spageektti spageektti spageektti approved these changes

@acuteenvy acuteenvy acuteenvy approved these changes

@kbdharun kbdharun kbdharun approved these changes

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page. page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Abhishek-1804 @tldr-bot @sebastiaanspeck @kbdharun @acuteenvy @spageektti